Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-6409): new errors for unacknowledged bulk writes #4276

Merged
merged 2 commits into from
Oct 14, 2024
Merged

feat(NODE-6409): new errors for unacknowledged bulk writes #4276

merged 2 commits into from
Oct 14, 2024

Conversation

durran
Copy link
Member

@durran durran commented Oct 14, 2024 •
edited
Loading

Description

Updates client bulk write to change the way it handles unacknowledged writes.

What is changing?

  • Error is thrown when w:0 and ordered is true.
  • Error is thrown when w:0 and verbose results are requested.
  • Syncs unified tests to latest.
  • Adds a new prose test for batching unacknowledged writes.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6409/DRIVERS-2993

mongodb/specifications#1670

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review October 14, 2024 15:53
@nbbeeken nbbeeken self-assigned this Oct 14, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 14, 2024
@nbbeeken nbbeeken self-requested a review October 14, 2024 17:13
nbbeeken
nbbeeken requested changes Oct 14, 2024
View reviewed changes
test/integration/crud/crud.prose.test.ts Outdated Show resolved Hide resolved
test/integration/crud/crud.prose.test.ts Outdated Show resolved Hide resolved
test/integration/crud/crud.prose.test.ts Show resolved Hide resolved
test/integration/crud/crud.prose.test.ts Outdated Show resolved Hide resolved
@durran durran requested a review from nbbeeken October 14, 2024 17:55
nbbeeken
nbbeeken approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken merged commit 7fde8dd into main Oct 14, 2024
30 checks passed
@nbbeeken nbbeeken deleted the NODE-6409 branch October 14, 2024 18:32
@github-actions github-actions bot mentioned this pull request Oct 14, 2024
Merged
@WontonSam WontonSam mentioned this pull request Nov 11, 2024
Open
@shafeeqd959 shafeeqd959 mentioned this pull request Nov 11, 2024
Open
@TartejBrothers TartejBrothers mentioned this pull request Nov 12, 2024
Merged
@akanchhaS akanchhaS mentioned this pull request Nov 12, 2024
Open
@zntb zntb mentioned this pull request Nov 12, 2024
Closed
@skanda890 skanda890 mentioned this pull request Nov 12, 2024
Merged
@thnbih thnbih mentioned this pull request Nov 12, 2024
Open
This was referenced Nov 13, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@durran @nbbeeken