Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security level settings are incorrectly documented in the yaml/readme files #25

Open
duncandrennan opened this issue Feb 28, 2022 · 0 comments

Comments

@duncandrennan
Copy link
Contributor

.yml and README.md have

0 - no auth required, 1 - encryption reqd, 2 - encryption + MITM reqd

Code has:

enum mgos_bt_gatt_sec_level {
  /* No authentication required */
  MGOS_BT_GATT_SEC_LEVEL_NONE = 0,
  /* Authenitcation required */
  MGOS_BT_GATT_SEC_LEVEL_AUTH = 1,
  /* Authentication and encryption required */
  MGOS_BT_GATT_SEC_LEVEL_ENCR = 2,
  /* Authentication, encryption and MITM protection required */
  MGOS_BT_GATT_SEC_LEVEL_ENCR_MITM = 3,
};

yaml & README need to be aligned. We picked this up when iOS threw errors while trying to use "1" with the assumption it was encrypted. With "2" iOS works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant