-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
@asbiin I need your help. I don't understand what's happening inside the ContactSelector component. Basically, inside the Edit view, the Contacts are passed as However, on page load, the contacts are not displayed, because the component thinks the localContacts variable is empty, even though ModelValue is not empty. I have no idea what's going on and why this is happening. |
@djaiss yes on page load == when vue run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm proposing some small changes, but otherwise it's great!
@@ -285,6 +286,10 @@ public static function modules(TemplatePage $page, Contact $contact, User $user) | |||
$data = ModulePhotosViewHelper::data($contact); | |||
} | |||
|
|||
if ($module->type == Module::TYPE_POSTS) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have used a switch
on the whole foreach, but it's more changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I won't do this in this PR but will do it. It'll be faster.
app/Domains/Vault/ManageJournals/Services/RemoveContactFromPost.php
Outdated
Show resolved
Hide resolved
…t.php Co-authored-by: Alexis Saettler <alexis@saettler.org>
Co-authored-by: Alexis Saettler <alexis@saettler.org>
Co-authored-by: Alexis Saettler <alexis@saettler.org>
Kudos, SonarCloud Quality Gate passed! |
This PR lets you associate a contact with a post.
You can associate as many contacts in a post as you want.
This uses the
ContactSelector
component that is also used on the Loan widget.