Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix add gender type #4548

Merged
merged 10 commits into from
Jan 1, 2021
Merged

Conversation

kavanpancholi
Copy link

This PR adds default value in the type field in the default gender selection form and adds validation of gender type selections.

Fixes Issue: #4381

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • Create your PR as draft if it is not final yet. Mark it as ready... when it’s ready. Otherwise the PR will be considered complete and rejected if it's not working.

General checks

  • Make sure that the change you propose is the smallest possible.
  • The name of the PR should follow the conventional commits guideline that the project follows.

Front-end changes

  • If you change the UI, make sure to ask repositories administrators first about your changes by pinging djaiss or asbiin in this PR.
  • Screenshots are included if the PR changes the UI.
  • Front-end tests have been written with Cypress.

Backend/models changes

  • The API has been updated.
  • API's documentation has been added by submitting a pull request in the marketing website repository.
  • Tests have been added for the new code.
  • If you change a model, make sure the SetupTest file is updated. We need seeders to develop locally and generate fake data.

If the code changes the SQL schema

  • Make sure exporting account data as SQL is still working.
  • Make sure your changes do not break importing data with vCard and .csv files.
  • Make sure account reset and deletion still work.

Other tasks

  • CHANGELOG entry added, if necessary, under UNRELEASED.
  • CONTRIBUTORS entry added, if necessary.
  • If it's relevant and worth mentioning, create a changelog entry for this change. The changelog entry will appear inside the UI for all users to see. To know if your change is worth the creation of a changelog entry, read the documentation.
  • Don't forget to ask for a free account on https://monicahq.com as anyone who contributes can request a free account.

@kavanpancholi
Copy link
Author

Hi @asbiin I think this PR will help to resolve a bug in "Add new gender type" in Monica Settings -> Personalization.
Can you look at this when you get some time?
Thanks

@asbiin asbiin changed the title fix: Fix add gender type #4381 fix: fix add gender type Dec 12, 2020
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kavanpancholi
See my comment below.

resources/js/components/settings/Genders.vue Outdated Show resolved Hide resolved
@kavanpancholi
Copy link
Author

Hi @asbiin, I've made changes as per your comment.
Now it picks the default gender from settings instead of the static value.
Also, There was an error in default gender validation which I've resolved in a separate commit.

@asbiin asbiin enabled auto-merge (squash) January 1, 2021 13:36
@asbiin asbiin merged commit c0561ce into monicahq:master Jan 1, 2021
@github-actions
Copy link

github-actions bot commented Jan 2, 2022

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants