Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add total of participants in activity #5474

Merged
merged 2 commits into from
Sep 1, 2021
Merged

feat: add total of participants in activity #5474

merged 2 commits into from
Sep 1, 2021

Conversation

MarkusDick
Copy link

@MarkusDick MarkusDick commented Aug 30, 2021

Feat / Fix: #4204

Adds total of participants in activities. See below for the screenshot.

I reduced the total by one, because in the array also the contact itself is indicated, but not in the displayed list.

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.

General checks

  • Make sure that the change you propose is the smallest possible.
  • The name of the PR should follow the conventional commits guideline that the project follows.

Front-end changes

  • If you change the UI, make sure to ask repositories administrators first about your changes by pinging djaiss or asbiin in this PR. (pinged in the issue)
  • Screenshots are included if the PR changes the UI.

Other tasks

show_total_participants_of_activity

Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@asbiin asbiin merged commit 9194eb3 into monicahq:master Sep 1, 2021
@github-actions
Copy link

github-actions bot commented Oct 9, 2021

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MarkusDick MarkusDick deleted the 4204-add-total-of-participants-in-activity branch October 13, 2021 08:41
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show total number of participants in events
2 participants