Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/people click on tag bug #5566

Closed
souhailmerroun opened this issue Oct 5, 2021 · 5 comments · Fixed by #5568
Closed

/people click on tag bug #5566

souhailmerroun opened this issue Oct 5, 2021 · 5 comments · Fixed by #5568
Labels

Comments

@souhailmerroun
Copy link

When you visit /people, you get a list of the tags on the right.

image

When you click on one of'em, you get to the filtered page. Example: /people?tags[]=Imported+on+05%2F10+from+LinkedIn

If you click on another tag, instead of being redirected to the filtered page, you get back to /people, it kinda just remove the filter.

@nhymxu
Copy link

nhymxu commented Oct 5, 2021

I think I know where error.
But what is your expectation?

  1. Link to only other tag.
  2. Link to combine two tags

@souhailmerroun
Copy link
Author

Good question.

I was expected to see only the other tag.

For combining tags, it would make more sense if the links became a sort of a checkbox or something else in term of UI/UX... Would definetly be fun to have a combination but of today even "Google Contacts" doesn't have this feature if i recall right.

@nhymxu
Copy link

nhymxu commented Oct 5, 2021

Maybe we need consider idea from @asbiin about origin design.

But I will create PR to fix combine multi tags filter.
And change later if I wrong

@github-actions
Copy link

github-actions bot commented Oct 9, 2021

🎉 This issue has been resolved in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

This issue has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants