Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Task.parSequence and Task.parTraverse aliases #1130

Closed
Avasil opened this issue Feb 18, 2020 · 4 comments
Closed

Add Task.parSequence and Task.parTraverse aliases #1130

Avasil opened this issue Feb 18, 2020 · 4 comments

Comments

@Avasil
Copy link
Collaborator

Avasil commented Feb 18, 2020

Task.parSequence = Task.gather
Task.parTraverse = Task.wander

@alexandru
Copy link
Member

I'm starting to dislike the proliferation of aliases in Monix.

WDYT? Should we deprecate the old names? We'll keep them for binary compatibility of course.

@Avasil
Copy link
Collaborator Author

Avasil commented Feb 19, 2020

I'm fine with deprecation in this example.
I suppose we should add parXXXUnordered and parXXXN as well?
I think in Cats it's called parUnorderedTraverse but we use wanderUnordered and wanderN

  1. If we are consistent with ourselves:
    parTraverse, parTraverseN, parTraverseUnordered

  2. If we are consistent with Cats:
    parTraverse, parTraverseN, parUnorderedTraverse

It's unfortunate but I would go with 1 because discoverability seems to be better

@jozic
Copy link
Contributor

jozic commented Feb 19, 2020

+1 for parTraverseUnordered

@jozic
Copy link
Contributor

jozic commented Mar 15, 2020

I'll take this if no objections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants