Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some task improvements:
Callback
, removed thepopBeforeCall
andasync
builders, because they were confusingCallback
now hasasyncOnSuccess
andasyncOnError
specified as extension methods (not methods on the class)Task.create
was changed to be safe, in that users are protected from stack-overflows on usage ofonSuccess
- this isn't always a good solution for performance reasons, but users knowing what they are doing always haveunsafeCreate
chooseFirstOfList
and ensured its stack safe - as part of it the implementation ofCompositeCancelable
was replaced with one that uses an internal mutableHashSet
TestScheduler
and as a result some tests are running dramatically faster