Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a geompp include directory #1

Open
musicinmybrain opened this issue May 18, 2021 · 2 comments
Open

Consider a geompp include directory #1

musicinmybrain opened this issue May 18, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@musicinmybrain
Copy link

In updating the Fedora Linux package for giada, I’m preparing to package this new build dependency as a separate header-only library. That means installing it in /usr/include/geompp since the header names are quite generic. To use it that way, I can patch the internal includes from:

#include "line.hpp"
#include "point.hpp"

to

#include "geompp/line.hpp"
#include "geompp/point.hpp"

Or, I can leave them as they were, and users of the package (at the moment this just means my own giada package build) need to add -I/usr/include/geompp or similar.

I was wondering if you had a preference—and, if you prefer the geompp directory, whether you would consider adding it upstream. If you intend this library to eventually be used by the “general public,” I would suggest the directory to reduce the possibility of header name conflicts. If it’s really only intended for giada, then I guess it doesn’t matter much at all.

@musicinmybrain
Copy link
Author

I’m going ahead with patching the internal includes in the Fedora package for now. This can be adjusted later if needed.

@gvnnz
Copy link
Contributor

gvnnz commented May 22, 2021

Thanks for the input @musicinmybrain , this is an interesting topic. The geompp library is/was intended to be used internally, that is only by Giada and few other projects. However I like the idea of making it production-ready, or at least to prepare it for the general public in a more or less distant future.

You are the expert here when it comes to packaging libraries - more expert than me, at least 😎 - I'll update the include path in one of the next commits.

@gvnnz gvnnz self-assigned this May 22, 2021
@gvnnz gvnnz added the enhancement New feature or request label May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants