Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated MOODLE_APP_VERSION variable not properly handled on Windows #166

Closed
NeillM opened this issue Jun 16, 2021 · 3 comments
Closed

Comments

@NeillM
Copy link
Contributor

NeillM commented Jun 16, 2021

If you use the MOODLE_APP_VERSION on windows the MOODLE_DOCKER_APP_VERSION variable is set with speech marks around it. i.e. as "latest", rather than latest causing moodle-docker not to start with a message like:

ERROR: no such image: moodlehq/moodleapp:"latest": invalid reference format

@NeillM
Copy link
Contributor Author

NeillM commented Jun 16, 2021

I have submitted a pull request to fix this.

@stronk7
Copy link
Member

stronk7 commented Jun 17, 2021

Related to this, I've created #168 to see if we can have Windows scripts covered in some way.

@stronk7
Copy link
Member

stronk7 commented Jun 17, 2021

Closing, now that #167 has been merged, thanks!

@stronk7 stronk7 closed this as completed Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants