Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider deprecating the DB env variable (long term) in favour of DB_TYPE #229

Open
stronk7 opened this issue May 31, 2023 · 0 comments
Open

Consider deprecating the DB env variable (long term) in favour of DB_TYPE #229

stronk7 opened this issue May 31, 2023 · 0 comments

Comments

@stronk7
Copy link
Member

stronk7 commented May 31, 2023

With #218 we have introduced a bunch of new DB environmental variables (DB_USER, DB_PASS, DB_HOST....).

So now, the previously existing DB is sort of exception / orphaned. This issue is about to:

  • Consider adding support for a new DB_TYPE env variable. It will have precedence over the existing DB one.
  • Start warning in logs about DB being considered deprecated.
  • Modify all the dist files and documentation to point to the new one.
  • Keep DB working long time (whole moodle-plugin-ci v4 at least).
  • On next major version, proceed to remove the deprecated option.

Ciao :-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stronk7