-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debounce to push button #401
Comments
there's actually already a debounce: https://github.com/mooltipass/minible/blob/master/source_code/main_mcu/src/INPUTS/inputs.c#L275, set to 100ms |
Nice. |
that's indeed a great idea! |
might this be the same reason why i sometimes dont get a wheel move when moving quickly through the numbers when trying to enter my pin? |
not exactly no |
I have this issue with my early unit, it seems the scroll wheel starts to do this after lots of use. This will just get worse and worse until the wheel stops working. I've replaced this unit with a new one that I think has a better scroll wheel installed. The new one doesn't exhibit any issues but it's only been 6 months. |
Hello, are you saying you aren't able to click anymore? |
I got same problem |
@seviu : can you expand on your symptoms? :) |
@limpkin I can click but it will sometimes scroll at the same time. Just touching the scroll wheel lightly will sometimes make it scroll very quickly in one direction or the other. If I push down on the scroll wheel while clicking it works much better. This leads me to think the issue is hardware, the scroll wheel has failed and the contacts and/or wheel are lose. I have a very early unit and I use it all the time so perhaps the scroll wheel part isn't robust enough. |
@CGuy-1 is this still happening? I could offer a device swap... |
Yes, I suspect the scroll wheel contacts are broken or worn out. This is an early unit and I use it all the time so it may just need a new scroll wheel component. The battery doesn't hold a charge any more (and yes I've run the refresh several times), is it possible to replace it? |
send me a quick email, we'll work something out :) |
Missing feature
Debouncing does not seem to be present when pressing down the button.
Maybe adding around 100ms would be nice.
Justification
Sometimes the button "double-clicked" by itself, occurrence seem to be 1 in 10 or less (at least on my device).
Although it does not seem much, but it is rather annoying when it happens, especially when entering the last digit pin, causing unwanted "invalid pin" incidents.
The text was updated successfully, but these errors were encountered: