Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incoming/odfi: allow specific shards to be triggered #100

Open
adamdecaf opened this issue Jun 9, 2022 · 2 comments
Open

incoming/odfi: allow specific shards to be triggered #100

adamdecaf opened this issue Jun 9, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request hacktoberfest-accepted help wanted Extra attention is needed

Comments

@adamdecaf
Copy link
Member

On the /trigger-inbound endpoint we don't allow the option of triggering some of the shards. Instead every shard is triggered by default. We should support triggering only some shards, which is how /trigger-cutoff works.

https://github.com/moov-io/achgateway/blob/v0.15.4/internal/incoming/odfi/admin.go#L35

@adamdecaf adamdecaf added enhancement New feature or request help wanted Extra attention is needed labels Jun 9, 2022
@adamdecaf adamdecaf added this to the v0.16.0 milestone Jun 14, 2022
@adamdecaf
Copy link
Member Author

@darwinz you mentioned wanting to do this change as well. Do you still want to? It should be much less code/work than adding the slack alerter.

@darwinz
Copy link
Contributor

darwinz commented Jun 17, 2022

@darwinz you mentioned wanting to do this change as well. Do you still want to? It should be much less code/work than adding the slack alerter.

Yeah, I'll take this one too @adamdecaf . Thanks for checking!

@adamdecaf adamdecaf modified the milestones: v0.16.0, v0.17.0 Jul 14, 2022
@adamdecaf adamdecaf removed this from the v0.18.0 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest-accepted help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants