Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action returns success even if there are active warnings/errors #26

Open
snir102002 opened this issue Jul 6, 2020 · 0 comments
Open

Comments

@snir102002
Copy link

snir102002 commented Jul 6, 2020

Hi all,
I'm trying to use this action on a repo with multiple projects that each has its own tsconfig and tslint files. when creating a PR and running the actions, it returns success even if there are violations in the code. of course that if I'm running the linter locally it works ok.
my project structure is as follows:

gallery
	tsconfig.json
	tslint.json (extends config from node modules)
lib
	tsconfig.json
	tslint.json (extends config from node modules)

tsconfig.json (common config)

The action in the workflow defined as follows for the gallery project and same for the lib:

- name: Linting gallery
   uses: mooyoul/tslint-actions@v1.1.0
   with:
     project: ./gallery/tsconfig.app.json
     config: ./gallery/tslint.json
     token: ${{ secrets.GITHUB_TOKEN }}

Any help will be appreciated :)

@snir102002 snir102002 changed the title Action returns success even if there in active warnings/errors Action returns success even if there are active warnings/errors Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant