Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify meaning of Timeout subscribe error #531

Open
englishm opened this issue Sep 18, 2024 · 6 comments
Open

Clarify meaning of Timeout subscribe error #531

englishm opened this issue Sep 18, 2024 · 6 comments
Assignees

Comments

@englishm
Copy link
Collaborator

As discussed on the call today when looking at #529

@englishm
Copy link
Collaborator Author

None of the other errors in that section have detailed descriptions yet either, but all the rest are more obvious.

@fluffy mentioned this likely being something to do with relays needing to conserve resources. Can probably check relevant meeting minutes/recording for additional details.

@englishm
Copy link
Collaborator Author

@ianswett (on 2024-02-14):

As discussed today, it'd be nice to have one indicating "Timeout".
#347 (comment)

The Datatracker doesn't have anything recorded for that date.

I think this must have been discussed on an authors' call before we switched to the weekly interim format.

Any additional detail from folks who were there for that discussion would be helpful.

@fluffy
Copy link
Contributor

fluffy commented Sep 19, 2024

I have on a vague recollection of priori discussion of this so take with a huge grain of salt but it seems like we might need something to deal with the case of S sends a subscribe to relay R, R sends subscribe publisher P, P never returns any response to the subscribe. Eventually R will want to give up and tell S that the subscribe did not work. In this case R needs some error to return to S.

@ianswett
Copy link
Collaborator

I think @fluffy is correct.

I'm curious what HTTP proxies do in this case today? Without looking at our code, I think a timeout would get converted into a 500, but I'm unsure?

@LPardue
Copy link
Contributor

LPardue commented Sep 24, 2024

I think my HTTP proxy tends to return a 502 or 504 depending on the exact circumstances

@afrind
Copy link
Collaborator

afrind commented Sep 24, 2024

I'm pretty sure this is always a 504 in our proxy.

@englishm englishm self-assigned this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants