Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does SUBSCRIBE_NAMESPACE return your own ANNOUNCE's #583

Open
afrind opened this issue Oct 7, 2024 · 2 comments · May be fixed by #643
Open

Does SUBSCRIBE_NAMESPACE return your own ANNOUNCE's #583

afrind opened this issue Oct 7, 2024 · 2 comments · May be fixed by #643
Assignees
Labels
Announce Issues with Announce message and handling

Comments

@afrind
Copy link
Collaborator

afrind commented Oct 7, 2024

In moq-chat, a subscriber does an ANNOUNCE for their namespace and a SUBSCRIBE_NS for a level higher prefix. Should the relay filter these announces, or forward them back to the originator?

@afrind afrind added the Announce Issues with Announce message and handling label Oct 8, 2024
@ianswett
Copy link
Collaborator

If it does, does it increase the potential for infinite loops, #556 ?

@afrind
Copy link
Collaborator Author

afrind commented Nov 11, 2024

Individual Comment:

I'm inclined to say a client should not be able to SUBSCRIBE to it's own tracks at a relay, though I had to temporarily allow this to interop with @suhasHere. In a similar vein, I think it's best to not return ANNOUNCE messages back to the originator. They really ought to know, and if we disallow self-subscribe, it's unclear what the use case is.

@martinduke martinduke linked a pull request Dec 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Announce Issues with Announce message and handling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants