Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delivery timeout cannot be expressed per subgroup #606

Open
fluffy opened this issue Nov 6, 2024 · 3 comments
Open

Delivery timeout cannot be expressed per subgroup #606

fluffy opened this issue Nov 6, 2024 · 3 comments

Comments

@fluffy
Copy link
Contributor

fluffy commented Nov 6, 2024

TTL got moved into delivery timeout in subscribe OK but that lost the property to set a different timeout for different sub groups.

It is not clear where a max cache parameter can be in the protocol.

It is not clear interaction of max cache and delivery timeout in subscribe OK are both needed.

@afrind afrind changed the title timeout properties got broken Delivery timeout cannot be expressed per subgroup Nov 6, 2024
@afrind
Copy link
Collaborator

afrind commented Nov 6, 2024

I renamed the issue to reflect the primary issue with the current draft.

It is not clear where a max cache parameter can be in the protocol.

This is true, let's file a separate issue. My understanding is that it's useful in both SUBSCRIBE_OK and FETCH_OK - does that seem right?

It is not clear interaction of max cache and delivery timeout in subscribe OK are both needed.

My understanding is:

DELIVERY_TIMEOUT only applies to SUBSCRIBE (not FETCH) -- how long should a relay attempt to deliver an object before dropping/resetting.
MAX_CACHE_DURATION tells a cache the max time to keep an object in cache (to serve via FETCH) before expiring it. A subsequent fetch after expiry would necessitate re-fetching from origin.

If that's right then having both in SUBSCRIBE_OK seems valid. If that's not right, let's file a separate issue for this too.

@suhasHere
Copy link
Collaborator

I wonder if we are talking about 3 different things here

  • per subgroup TTL, set by the original publisher --> we don't have a way tp specify this today.
  • subscriber requested delivery timeout -> @afrind i concur on your definition on this one
  • cache duration ( set by the publisher, but can be effected by relay policy ?) --> @afrind aligning with you

Also I agree subscribe_ok should reflect these values as they serve different purposes .

@martinduke
Copy link
Contributor

I don't understand the use case for different delivery timeouts. Surely the delivery timeout relates to when the media will be consumed, which is independent of priority?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants