-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with Moq.pdb in version 4.7.99: "Symbol indexes could not be retrieved" #428
Comments
Can you please describe in more detail what you're attempting to do? (For example, as I understand it, you should consume the symbols, not publish them. What location are you publishing to?) |
Thanks for the quick answer! To be honest, I am not sure what is going on under the hood. I am using a TFS build that has a step "Index sources & publish symbols". That step was working with my previous moq dependency (4.7.1) and not anymore. I will try to find out more about what it is trying to do. |
I'm wondering why TFS would even attempt to source-index a third-party dependency's PDBs. The change here (as mentioned in the changelog) is that Moq 4.7.99 now includes PDBs again (for the first time since version 4.5.7), and they are already source-indexed. The PDBs are of the new "portable" variety btw., perhaps you are using an older release of TFS that doesn't understand them yet? Some options that I can think of:
|
I will check that, I wonder indeed why it does not only work on my component pdb. |
@epot: Possibly because your component uses the classic PDB format ( Btw. I edited the above answer and added some more options for you to try. |
I am also getting the same issue with a hosted build in team services online I have downgraded moq in the meantime |
It looks like to be a standard build step to try to retrieve the symbols from the 3rd parties pdb (for instance, another component causing an issue: sendgrid/sendgrid-csharp#494). I think I will also downgrade for the time being. |
As suggested in this comment over at sendgrid/sendgrid-csharp#494 and on the condition that SourceLink supports the classic PDB format, I might also change the .NET 4.5 target's PDB back to I'll monitor the referenced issue to see how it resolves. |
+1 I hit this tonight. I backed off to the previous version and the build is working just fine for now. I will keep an eye out for a new version that works with VSTS and .Net 4.5. Thanks |
Unfortunately we cannot resolve this issue like the Sendgrid folks did, because we're source linking the Moq PDBs, and SourceLink isn't supported yet for classic / Windows PDBs. This will change with Roslyn / VS 15.3, see dotnet/roslyn#18539. We have about three options on how to proceed:
My personal preference is option (3). Any thoughts? |
We've just run in to this same issue. Now that 15.3 has been released is this back on the radar to move over to Windows PDBs? |
@epot, @Magrangs, @gregveres, @rh072005 - I have prepared a potential fix for your issues (switching from portable PDBs back to classic PDBs, see the PR referenced above), but I can't actually test it as I don't have access to TFS. Would any of you be willing to test an out-of-band, prerelease version of Moq (4.7.100-pre, temporarily available here) and see if it resolves your issues? |
@stakx I've just given that a go and it's working for us |
OK this should be fixed by #443 in the next release of Moq (version > 4.7.99). It would be a pity if Moq had to remain with classic PDBs forever, I guess we'll make the switch back to portable PDBs sometime in the future (perhaps in 2018). Until then let's give the new portable PDB format some more time to gain momentum and better tooling support. |
I had the same issue, thanks for correcting it :) When is next released planned ? |
@TechWatching: I am still waiting for feedback on one or two issues, but I was looking at publishing an updated version of Moq in the next 2 weeks or so. |
Just for those of you still watching this issue, version 4.7.127 is out. Back to Windows PDBs, hope this helps. |
We want to continue publishing SourceLink-ed debug symbols, but using classic Windows PDBs generates a huge package. Using the much smaller portable PDB format would be much better, but some people may still experience problems with those. (See e.g. GitHub issue devlooped#428.) Let's follow the official guidance (see links below) and publish debug symbols in a separate `.snupkg` package to NuGet's symbol server. This means that we can (must, in fact) use portable PDBs as it will be the consumers' choice whether to use the separate symbols or not. References: * https://docs.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg * https://github.com/dotnet/SourceLink#alternative-pdb-distribution
We want to continue publishing SourceLink-ed debug symbols, but using classic Windows PDBs generates a huge package. Using the much smaller portable PDB format would be much better, but some people may still experience problems with those. (See e.g. GitHub issue devlooped#428.) Let's follow the official guidance (see links below) and publish debug symbols in a separate `.snupkg` package to NuGet's symbol server. This means that we can (must, in fact) use portable PDBs as it will be the consumers' choice whether to use the separate symbols or not. References: * https://docs.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg * https://github.com/dotnet/SourceLink#alternative-pdb-distribution
We want to continue publishing SourceLink-ed debug symbols, but using classic Windows PDBs generates a huge package. Using the much smaller portable PDB format would be much better, but some people may still experience problems with those. (See e.g. GitHub issue devlooped#428.) Let's follow the official guidance (see links below) and publish debug symbols in a separate `.snupkg` package to NuGet's symbol server. This means that we can (must, in fact) use portable PDBs as it will be the consumers' choice whether to use the separate symbols or not. References: * https://docs.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg * https://github.com/dotnet/SourceLink#alternative-pdb-distribution
I am getting an error when trying to publish the symbols:
The text was updated successfully, but these errors were encountered: