Revert "lightningd: close plugin dir on return"

morehouse · morehouse · commit 0d686d14873a · 2023-06-05T15:38:23.000-05:00
This reverts commit 4f30857.
diff --git a/lightningd/plugin.c b/lightningd/plugin.c
@@ -1703,11 +1703,9 @@ char *add_plugin_dir(struct plugins *plugins, const char *dir, bool error_ok)
 		} else {
 			p = plugin_register(plugins, fullpath, NULL, false,
 					    NULL, NULL);
-			if (!p && !error_ok) {
-				closedir(d);
+			if (!p && !error_ok)
 				return tal_fmt(NULL, "Failed to register %s: %s",
 				               fullpath, strerror(errno));
-			}
 		}
 	}
 	closedir(d);

Original file line number	Diff line number	Diff line change
`@@ -1703,11 +1703,9 @@ char add_plugin_dir(struct plugins plugins, const char *dir, bool error_ok)`
`1703`	`1703`	`} else {`
`1704`	`1704`	`p = plugin_register(plugins, fullpath, NULL, false,`
`1705`	`1705`	`NULL, NULL);`
`1706`		`- if (!p && !error_ok) {`
`1707`		`- closedir(d);`
	`1706`	`+ if (!p && !error_ok)`
`1708`	`1707`	`return tal_fmt(NULL, "Failed to register %s: %s",`
`1709`	`1708`	`fullpath, strerror(errno));`
`1710`		`- }`
`1711`	`1709`	`}`
`1712`	`1710`	`}`
`1713`	`1711`	`closedir(d);`