Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add net47 as a targetFramework #611

Closed
chinwobble opened this issue Sep 28, 2019 · 1 comment
Closed

Add net47 as a targetFramework #611

chinwobble opened this issue Sep 28, 2019 · 1 comment

Comments

@chinwobble
Copy link

If you create a net472 application and reference MoreLinq 3.2.0 it will also unnecessarily bring in System.ValueTuple even though the framework already has it.

The way nuget framework resolution works is that it will look for a target framework of the same family. In this case my net472 app is "closets" to net451 of morelinq rather than netstandard2.0 even though that is also compatible.

See here for more details.
NuGet/Home#5370

Can we add another net47 target without a dependency on System.ValueTuple
The benefit for consuming projects is that they do need to load this assembly which improve startup times.

@atifaziz
Copy link
Member

atifaziz commented Oct 2, 2019

I'm closing this as a duplicate of #348. Please see the discussion there.

The benefit for consuming projects is that they do need to load this assembly which improve startup times.

Do you have any number to share on the difference it makes in the start-up time?

@atifaziz atifaziz closed this as completed Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants