Fix Memoize Implementation
#898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceroypenguin
commented
Nov 20, 2022
| enumerator.MoveNextCalled += (_, moved) => | ||
| { | ||
| Assert.That(ended, Is.False, "LINQ operators should not continue iterating a sequence that has terminated."); |
There was a problem hiding this comment.
Per the specification, it is not a failure to call .MoveNext() after receiving a false response. The enumerator is simply expected to continue to return false for each following call.
viceroypenguin
commented
Nov 20, 2022
| @@ -69,14 +69,11 @@ public IEnumerator<T> GetEnumerator() | |||
| _disposed = false; | |||
| enumerator.Disposed += delegate | |||
| { | |||
| Assert.That(_disposed, Is.False, "LINQ operators should not dispose a sequence more than once."); | |||
There was a problem hiding this comment.
Per the specification, it is not a failure to call .Dispose() multiple times. The .Dispose() method is expected to be idempotent, such that it is callable multiple times without throwing an exception.
Codecov Report
@@ Coverage Diff @@
## master #898 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 110 110
Lines 3441 3441
Branches 1020 1020
=======================================
Hits 3179 3179
Misses 200 200
Partials 62 62 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Upon further review, this is the incorrect path to address concerns anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things: 1) Correct issues in
Memoizeimplementation; 2) Update tests forMemoizeandCartesianto reflect updated expectations; 3) UpdateTestingSequencewith better expectations for how a testing sequence should be used.Fixes #889