Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR mergeablity criteria #45

Open
rexim opened this issue Feb 20, 2017 · 1 comment
Open

PR mergeablity criteria #45

rexim opened this issue Feb 20, 2017 · 1 comment
Assignees

Comments

@rexim
Copy link
Member

rexim commented Feb 20, 2017

At https://github.com/morganey-lang/Morganey sometimes we have a problem because of the lack of such criteria. It's always unclear whom to request to review certain changes. And when the requested reviewers are unavailable it may create a sense of obligation which is not good for the community. I propose to introduce clear criteria of PR mergeability. For example:

  • All CI checks are passed
  • At least one approved review
  • After certain amount of time without an approved review Project Leader decided whether to merge pull request or not.

I'd like to emphasize that when someone is requested for a review they are not obligated to do the review. It is always a friedly request to take a look at the code if they have a chance.

Also, we always talk about Project Leaders and their responsibilities. I want to also state somewhere that Leader's responsibility doesn't mean obligation. Project Leadership means Ownership. When you own a personal repo you are responsible for it but are not obligated to do anything for it.

@rexim rexim self-assigned this Feb 20, 2017
@ForNeVeR
Copy link
Member

It is always a friedly request

image

Yes, that exactly 😂

That's also important that it's Project Leader responsibility to manage the pull request queue; PL is the project maintainer.

I approve that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants