You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At https://github.com/morganey-lang/Morganey sometimes we have a problem because of the lack of such criteria. It's always unclear whom to request to review certain changes. And when the requested reviewers are unavailable it may create a sense of obligation which is not good for the community. I propose to introduce clear criteria of PR mergeability. For example:
All CI checks are passed
At least one approved review
After certain amount of time without an approved review Project Leader decided whether to merge pull request or not.
I'd like to emphasize that when someone is requested for a review they are not obligated to do the review. It is always a friedly request to take a look at the code if they have a chance.
Also, we always talk about Project Leaders and their responsibilities. I want to also state somewhere that Leader's responsibility doesn't mean obligation. Project Leadership means Ownership. When you own a personal repo you are responsible for it but are not obligated to do anything for it.
The text was updated successfully, but these errors were encountered:
At https://github.com/morganey-lang/Morganey sometimes we have a problem because of the lack of such criteria. It's always unclear whom to request to review certain changes. And when the requested reviewers are unavailable it may create a sense of obligation which is not good for the community. I propose to introduce clear criteria of PR mergeability. For example:
I'd like to emphasize that when someone is requested for a review they are not obligated to do the review. It is always a friedly request to take a look at the code if they have a chance.
Also, we always talk about Project Leaders and their responsibilities. I want to also state somewhere that Leader's responsibility doesn't mean obligation. Project Leadership means Ownership. When you own a personal repo you are responsible for it but are not obligated to do anything for it.
The text was updated successfully, but these errors were encountered: