Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): upgrade Angular dependencies to v15 #186

Merged
merged 6 commits into from
Jun 14, 2023

Conversation

un1c0rnr1d3r
Copy link
Collaborator

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Angular v14 dependencies are in use.

What is the new behavior?
Angular dependencies have been upgraded to v15.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@coveralls
Copy link

coveralls commented Apr 23, 2023

Coverage Status

Coverage: 100.0%. Remained the same when pulling f73e19e on upgrade-deps-angular-15 into 2458281 on master.

grbsk
grbsk previously approved these changes May 18, 2023
@grbsk
Copy link
Owner

grbsk commented May 18, 2023

@un1c0rnr1d3r The peer dependencies for core and keepalive package.json still have >=9.0.0. Is this update safe for projects that targets those versions still, or do we need to bump these requirements up?

If no, then I can just release this as another patch to v12. If yes, then we'll need to set the minimum version and add that as a breaking change, moving ng-idle to 13.

@grbsk grbsk self-requested a review May 18, 2023 04:19
@grbsk grbsk dismissed their stale review May 18, 2023 04:20

Missed potential peerDependencies issue

@un1c0rnr1d3r
Copy link
Collaborator Author

@moribvndvs Technically, Angular does not support building an application using a version older than the one the library was built with. However, I think this release should continue to work (albeit officially unsupported) with Angular v9+.

@grbsk grbsk merged commit a5a7095 into master Jun 14, 2023
@grbsk grbsk deleted the upgrade-deps-angular-15 branch June 14, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants