-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core & keepalive): [On behalf of Planally Sdn Bhd]: Angular 17 migration #200
Conversation
Migrated to angular 17 and upgraded peerdependencies of core and keepalive to angular 17 BREAKING CHANGE: 🧨 New angular version upgradation
Exposed providers array from module files
Used standalone component in docs example BREAKING CHANGE: 🧨 Remvoed regular component and App Module, Introduced AppConfig to configure necessary services
Fixed test running issue for docs
Angular 17 starts with minimum of node 18
Thanks @BhuiyanSaif18 for this PR. |
Any chance for a migration guide from how it used to work with Module vs how to use it now? |
Hi @HarelM, This PR added support for new service registration approach in ApplicationConfig.
Now in the new ApplicationConfig approach we register the NgIdle services like this & remove the
Now this ApplicationConfig allows us to register the service at root level, we can move service registration to component level with Please do let me know if you need more clarifications. |
Thanks for the info! This was very helpful. |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Although this PR helped us to use with standalone component, but the old NgModule approach is still available to use.