Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node#_important was deprecated. Use Node#raws.important #20

Closed
dmnsgn opened this issue Aug 26, 2015 · 5 comments
Closed

Node#_important was deprecated. Use Node#raws.important #20

dmnsgn opened this issue Aug 26, 2015 · 5 comments

Comments

@dmnsgn
Copy link
Contributor

dmnsgn commented Aug 26, 2015

Version 1.0.0, running cssfmt test.css in command line return Node#_important was deprecated. Use Node#raws.important

It looks like it is only happening for .css file though, not .scss.

@matype
Copy link
Owner

matype commented Aug 27, 2015

@dmnsgn Please gime me an example CSS code that error occurs.

@dmnsgn
Copy link
Contributor Author

dmnsgn commented Aug 27, 2015

@morishitter I used the input.css from the README

@matype
Copy link
Owner

matype commented Aug 27, 2015

CSSfmt passed the test case in README example code, and I tried to it in my PC using CSSfmt v1.0.0.
But, no error occurs.

@dmnsgn
Copy link
Contributor Author

dmnsgn commented Aug 27, 2015

You mean this https://github.com/morishitter/cssfmt/blob/master/test/fixtures/readme.css ? Because it is using the SCSS syntax with mixin, @extend .
I started from scratch, installed cssfmt globally then I used the following CSS (taken from the README), ran cssfmt input.css and then the error occurs (tested on 3 different platforms).

      @media screen and (    min-width :699px)
 {.foo    +       .bar,.hoge{
    font-size   :12px      !   important   ;  ~       .fuga     {
      padding      : 10px       5px;
   color:green;
 >p

 {
        line-height             : 1.5          ;
      }}}
     }                /* comment for .class, #id */


.class,           #id
 {     color       : blue;

  border        :solid  #ddd                1px}

@matype
Copy link
Owner

matype commented Aug 27, 2015

I understarnd. Thank you for your report. I will fix this :)

@matype matype closed this as completed in 9255ee5 Aug 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants