Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible further improvements from codereview2 #48

Open
LKKTWH opened this issue Jan 23, 2025 · 0 comments
Open

Possible further improvements from codereview2 #48

LKKTWH opened this issue Jan 23, 2025 · 0 comments

Comments

@LKKTWH
Copy link

LKKTWH commented Jan 23, 2025

For the functions and usability:
Core functions for parallel coordinate plots have been implemented, like multi-dimensional data visualization, normalization of the data, error handling for invalid inputs, etc. For further improvement, features like ‘axis reordering’, ‘brushing and linking’ could be added & axis can be scaled.

For documentation:
Uage examples are documented. Error messages are clear. But the architecture overview is missing. Tutorial guidance is limited. More examples can be added for advanced use.

For code structure: some functions can be split into smaller units. And logging function can be implemented.

For tests: the tests are comprehensive covering main functionality, edge cases, and validating input datasets, etc. But for large datasets, the stress test cases are not enough. Maybe also more benchmark comparisons.

For performance: consider pre-allocating arrays, parallel processing for larger datasets, and catching normalized values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant