pr feedback

Author: moritzzimmer

README.md

@@ -415,7 +415,7 @@ No modules.
 | <a name="input_kms_key_arn"></a> [kms\_key\_arn](#input\_kms\_key\_arn) | Amazon Resource Name (ARN) of the AWS Key Management Service (KMS) key that is used to encrypt environment variables. If this configuration is not provided when environment variables are in use, AWS Lambda uses a default service key. If this configuration is provided when environment variables are not in use, the AWS Lambda API does not save this configuration and Terraform will show a perpetual difference of adding the key. To fix the perpetual difference, remove this configuration. | `string` | `""` | no |
 | <a name="input_lambda_at_edge"></a> [lambda\_at\_edge](#input\_lambda\_at\_edge) | Enable Lambda@Edge for your Node.js or Python functions. Required trust relationship and publishing of function versions will be configured. | `bool` | `false` | no |
 | <a name="input_layers"></a> [layers](#input\_layers) | List of Lambda Layer Version ARNs (maximum of 5) to attach to your Lambda Function. | `list(string)` | `[]` | no |
-| <a name="input_logging_config"></a> [logging\_config](#input\_logging\_config) | The function's Amazon CloudWatch Logs configuration settings. | <pre>object({<br/>    log_format            = string<br/>    application_log_level = optional(string, null)<br/>    log_group             = optional(string, null)<br/>    system_log_level      = optional(string, null)<br/>  })</pre> | `null` | no |
+| <a name="input_logging_config"></a> [logging\_config](#input\_logging\_config) | Configuration block for advanced logging settings. | <pre>object({<br/>    log_format            = string<br/>    application_log_level = optional(string, null)<br/>    log_group             = optional(string, null)<br/>    system_log_level      = optional(string, null)<br/>  })</pre> | `null` | no |
 | <a name="input_memory_size"></a> [memory\_size](#input\_memory\_size) | Amount of memory in MB your Lambda Function can use at runtime. | `number` | `128` | no |
 | <a name="input_package_type"></a> [package\_type](#input\_package\_type) | The Lambda deployment package type. Valid values are Zip and Image. | `string` | `"Zip"` | no |
 | <a name="input_publish"></a> [publish](#input\_publish) | Whether to publish creation/change as new Lambda Function Version. | `bool` | `false` | no |

examples/complete/main.tf

@@ -31,18 +31,19 @@ module "lambda" {
   cloudwatch_lambda_insights_enabled = true
   layers                             = ["arn:aws:lambda:${local.region}:580247275435:layer:LambdaInsightsExtension-Arm64:23"]
 
-  environment = {
-    variables = {
-      key = "value"
-    }
-  }
-
+  // Advanced logging configuration
   logging_config = {
     log_format            = "JSON"
     application_log_level = "INFO"
     system_log_level      = "WARN"
   }
 
+  environment = {
+    variables = {
+      key = "value"
+    }
+  }
+
   // AWS Systems Manager (SSM) Parameter Store
   ssm = {
     parameter_names = ["/internal/params", "/external/params"]

main.tf

@@ -87,7 +87,6 @@ resource "aws_lambda_function" "lambda" {
     }
   }
 
-
   // create the CloudWatch log group first so it's no create automatically
   // by AWS Lambda
   depends_on = [aws_cloudwatch_log_group.lambda]

variables.tf

@@ -250,18 +250,14 @@ variable "vpc_config" {
 }
 
 variable "logging_config" {
-  description = "The function's Amazon CloudWatch Logs configuration settings."
+  description = "Configuration block for advanced logging settings."
   default     = null
   type = object({
     log_format            = string
     application_log_level = optional(string, null)
     log_group             = optional(string, null)
     system_log_level      = optional(string, null)
   })
-  validation {
-    condition     = var.logging_config == null || (var.logging_config.log_format == "JSON" || var.logging_config.log_format == "Text")
-    error_message = "log_format must be either 'JSON' or 'Text'"
-  }
 }
 
 variable "iam_role_name" {