chore: fixed tflint errors (#105)

Author: moritzzimmer

.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 repos:
   - repo: https://github.com/antonbabenko/pre-commit-terraform
-    rev: v1.83.4
+    rev: v1.83.5
     hooks:
       - id: terraform_fmt
       - id: terraform_validate
@@ -14,7 +14,7 @@ repos:
         args:
           - '--args=--lockfile=false'
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.4.0
+    rev: v4.5.0
     hooks:
       - id: check-merge-conflict
       - id: trailing-whitespace

cloudwatch_event_rules.tf

@@ -4,7 +4,7 @@ resource "aws_lambda_permission" "cloudwatch_events" {
   action        = "lambda:InvokeFunction"
   function_name = var.function_name
   principal     = "events.amazonaws.com"
-  qualifier     = contains(keys(each.value), "cloudwatch_event_target_arn") ? trimprefix(lookup(each.value, "cloudwatch_event_target_arn"), "${local.function_arn}:") : null
+  qualifier     = contains(keys(each.value), "cloudwatch_event_target_arn") ? trimprefix(each.value["cloudwatch_event_target_arn"], "${local.function_arn}:") : null
   source_arn    = aws_cloudwatch_event_rule.lambda[each.key].arn
 }
 

sns_subscriptions.tf

@@ -4,14 +4,14 @@ resource "aws_lambda_permission" "sns" {
   action        = "lambda:InvokeFunction"
   function_name = var.function_name
   principal     = "sns.amazonaws.com"
-  qualifier     = contains(keys(each.value), "endpoint") ? trimprefix(lookup(each.value, "endpoint"), "${local.function_arn}:") : null
-  source_arn    = lookup(each.value, "topic_arn")
+  qualifier     = contains(keys(each.value), "endpoint") ? trimprefix(each.value["endpoint"], "${local.function_arn}:") : null
+  source_arn    = each.value["topic_arn"]
 }
 
 resource "aws_sns_topic_subscription" "subscription" {
   for_each = var.sns_subscriptions
 
   endpoint  = lookup(each.value, "endpoint", local.function_arn)
   protocol  = "lambda"
-  topic_arn = lookup(each.value, "topic_arn")
+  topic_arn = each.value["topic_arn"]
 }