Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.4.1 introduces mousedown/mouseup bug on click to select #568

Closed
lvpro opened this issue Sep 10, 2018 · 7 comments
Closed

9.4.1 introduces mousedown/mouseup bug on click to select #568

lvpro opened this issue Sep 10, 2018 · 7 comments

Comments

@lvpro
Copy link

lvpro commented Sep 10, 2018

Are you reporting a bug?

Yes.

https://codepen.io/anon/pen/KxQovE

(Note, this required changing the loaded version on Codepen to 9.4.1).

  1. Focus on the autosuggestion input field.
  2. Type c, and wait for suggestions to appear
  3. CLICK on a suggestion.
  4. Now click on the second input box below.

Observed behavior:
Focus goes back to autosuggestion.

Expected behavior:
Focus should not go back to autosuggestion. This began in 9.4.1 today.

@moroshko
Copy link
Owner

@lvpro Thanks for reporting this!

@aberezkin Mind taking a look at this regression?

@stefangu
Copy link

We are having the same problem, started recently. We are using the standalone UMD build.

@aberezkin
Copy link
Collaborator

@moroshko Yep, I'll have a look.

@ghost
Copy link

ghost commented Sep 13, 2018

@aberezkin @moroshko
There's another regression related to unwanted input focus, coming from code in v9.4.1.
focusInputOnSuggestionClick prop seems to be ignored now inside onBlur handler, as it will still call input.focus().

This might actually warrant renaming a prop slightly or introducing a prop, but in any case seems like an unwanted behavior.
Will be rolling back to v9.4.0 for now as well.

@lvpro
Copy link
Author

lvpro commented Sep 14, 2018

Can we get this pushed to npm?

@moroshko
Copy link
Owner

@maxkolyanov Could you provide a repro for the regression you found in 9.4.1, and open a new issue?

@ghost
Copy link

ghost commented Sep 17, 2018

@moroshko It might be resolved by #572, will look into it and file an issue if it persists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants