Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of detail in errors #137

Closed
julien-devatom opened this issue Oct 3, 2023 · 4 comments · Fixed by #141
Closed

Lack of detail in errors #137

julien-devatom opened this issue Oct 3, 2023 · 4 comments · Fixed by #141
Assignees

Comments

@julien-devatom
Copy link
Contributor

https://github.com/morpho-labs/morpho-blue-metamorpho/blob/eb2d02b1faee86abe6072cc72212616af7a3c554/src/MetaMorpho.sol#L247

Here, you need to find out which market is reverting. Custom errors have been implemented for that: You can add parameters to the error (check doc here) So I suggest to use custom errors here and providing the first market that is reverting.

@Rubilmax
Copy link
Contributor

Rubilmax commented Oct 3, 2023

Agreed, but then let's use custom errors everywhere... And we roll back conventions. Agility!

@julien-devatom
Copy link
Contributor Author

For this specific use case, I'm in favor. In blue, we are never handling lists or SG like that so its ok.

@Rubilmax
Copy link
Contributor

Rubilmax commented Oct 3, 2023

And also blue is a "primitive"

@MerlinEgalite
Copy link
Contributor

Seen in a call with @Rubilmax let's do that. Too bad it's not synchronized with bundlers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants