-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lack of detail in errors #137
Comments
Agreed, but then let's use custom errors everywhere... And we roll back conventions. Agility! |
For this specific use case, I'm in favor. In blue, we are never handling lists or SG like that so its ok. |
And also blue is a "primitive" |
Seen in a call with @Rubilmax let's do that. Too bad it's not synchronized with bundlers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/morpho-labs/morpho-blue-metamorpho/blob/eb2d02b1faee86abe6072cc72212616af7a3c554/src/MetaMorpho.sol#L247
Here, you need to find out which market is reverting. Custom errors have been implemented for that: You can add parameters to the error (check doc here) So I suggest to use custom errors here and providing the first market that is reverting.
The text was updated successfully, but these errors were encountered: