Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reach 100% branch coverage #381

Closed
MerlinEgalite opened this issue Aug 20, 2023 · 4 comments
Closed

Reach 100% branch coverage #381

MerlinEgalite opened this issue Aug 20, 2023 · 4 comments
Assignees
Labels

Comments

@MerlinEgalite
Copy link
Contributor

MerlinEgalite commented Aug 20, 2023

Right now we're at 96.08%.

Screenshot 2023-08-20 at 10 19 14
@MathisGD
Copy link
Contributor

@MathisGD
Copy link
Contributor

FYI: forge coverage can't work on libraries (ref: foundry-rs/foundry#2567)

@MathisGD
Copy link
Contributor

MathisGD commented Aug 20, 2023

I checked quickly, and the 4 branches that are "not tested" in Morpho are the 4 callbacks. But in reality they are, so it's more a bug from forge coverage. I remember @makcandrov talking about this I think.

Then this issue is more a foundry PR

@MathisGD
Copy link
Contributor

If someone want to spend some time debugging forge, feel free to reopen this PR but I'm not sure it's worth. Coverage adds limited guarantees anyway.

@MathisGD MathisGD closed this as not planned Won't fix, can't repro, duplicate, stale Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants