Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Make kafka consumer options configurable #162

Open
svarkey opened this issue Nov 28, 2016 · 1 comment
Open

Make kafka consumer options configurable #162

svarkey opened this issue Nov 28, 2016 · 1 comment

Comments

@svarkey
Copy link
Contributor

svarkey commented Nov 28, 2016

I noticed that kafka consumer options like fromOffset,autoCommit are hard coded. It would be nice if we allow these options configurable

that._consumer = new Consumer(that._consumerClient, subscriptions, {
               groupId: groupId,fromOffset: true, autoCommit: false, encoding: "buffer"});
        }
@mcollina
Copy link
Collaborator

Good Spot!!! Can you please send a PR for this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants