Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quickstart tests error #558

Closed
seeflood opened this issue May 11, 2022 · 3 comments · Fixed by #562
Closed

quickstart tests error #558

seeflood opened this issue May 11, 2022 · 3 comments · Fixed by #562
Labels
area/ci bug Something isn't working help wanted Extra attention is needed

Comments

@seeflood
Copy link
Member

seeflood commented May 11, 2022 •
edited
Loading

What happened:
Error occus when running the quickstart tests in #557 .
But it didn't interrupt execution and finally report an success. See https://github.com/mosn/layotto/runs/6384572067?check_suite_focus=true
image

What you expected to happen:

  1. The quickstart tests run successfully
  2. If it fails , it should interrupt the execution and report an error

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:
@seeflood seeflood added bug Something isn't working area/ci labels May 11, 2022
@seeflood seeflood changed the title quickstart tests failed quickstart tests error May 11, 2022
@seeflood seeflood mentioned this issue May 11, 2022
Closed
25 tasks
@seeflood seeflood added the help wanted Extra attention is needed label May 12, 2022
@seeflood seeflood mentioned this issue May 13, 2022
Merged
@seeflood seeflood self-assigned this May 13, 2022
@akkw
Copy link
Contributor

akkw commented May 13, 2022

这个我来做吧

@seeflood
Copy link
Member Author

@akkw Sorry I already submitted PR for it #561 😢

@seeflood seeflood reopened this May 19, 2022
@seeflood
Copy link
Member Author

seeflood commented May 19, 2022 •
edited
Loading

I found there are still errors in https://github.com/mosn/layotto/runs/6491118102?check_suite_focus=true
and they didn't interrupt the execution 😢
image

@seeflood seeflood removed their assignment May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: fix CI issues and improve make script seeflood/layotto
2 participants
@seeflood @akkw