Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WavGAN paper recommends against upsampling. #10

Open
nickwharrington44 opened this issue Jan 26, 2023 · 0 comments
Open

WavGAN paper recommends against upsampling. #10

nickwharrington44 opened this issue Jan 26, 2023 · 0 comments

Comments

@nickwharrington44
Copy link

nickwharrington44 commented Jan 26, 2023 •
edited
Loading

Thanks very much for making this repo!

Quick comment is that, as I understand it, the WavGAN paper actually does not recommend nearest neighbor upsampling, and instead better results were obtained by the standard ConvTranspose approach. However, in model.py, the class "Transpose1dLayer" has a comment saying that upsampling IS recommended and the class "WaveGANGenerator" has upsampling enabled by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nickwharrington44