Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix #137 #138

Merged
merged 2 commits into from
Sep 25, 2023
Merged

fix: fix #137 #138

merged 2 commits into from
Sep 25, 2023

Conversation

motss
Copy link
Owner

@motss motss commented Sep 25, 2023

Description

Fixes #137 by merging all of them instead of removing \xDF.

'\xDF' (U+00df) is a duplicate of '\u00DF' (U+00df) 

Changes

  1. Remove ss match
  2. Remove \xDF
  3. Update tests to include Muße
  4. Update dependencies

Signed-off-by: Rong Sen Ng (motss) <wes.ngrongsen@gmail.com>
@motss motss added the bug label Sep 25, 2023
@motss motss self-assigned this Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #138 (a5c8adc) into main (5f96d66) will not change coverage.
Report is 8 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #138   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          152       151    -1     
  Branches         5         5           
=========================================
- Hits           152       151    -1     
Flag Coverage Δ
unit_tests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/diacritics.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@socket-security
Copy link

socket-security bot commented Sep 25, 2023

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@reallyland/tools 0.3.0...0.3.5 network, shell +222/-66 144 MB motss
tslib 2.4.1...2.6.2 None +0/-0 84 kB typescript-bot
typescript 4.9.4...5.2.2 None +0/-0 40.6 MB typescript-bot

Signed-off-by: Rong Sen Ng (motss) <wes.ngrongsen@gmail.com>
@motss motss merged commit 8001f93 into main Sep 25, 2023
7 checks passed
@motss motss deleted the fix/137 branch September 25, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The letter ß (Eszett) should be normalized to ss
1 participant