Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add catkin_lint #11

Closed
130s opened this issue Aug 22, 2016 · 4 comments
Closed

Add catkin_lint #11

130s opened this issue Aug 22, 2016 · 4 comments

Comments

@130s
Copy link
Contributor

130s commented Aug 22, 2016

e.g. Malformatted package.xml moveit/moveit_msgs#26 (comment) wasn't captured so far at anywhere in Pull Request --> ros.org Release pipeline afaik.

Having an optional job to run catkin_lint in CI may be one way to solve it.

cf. Related discussion ros-industrial/industrial_ci#58
@130s 130s mentioned this issue Aug 22, 2016
Merged
@v4hn
Copy link

v4hn commented Aug 22, 2016

+2

But this makes only sense after the rest of MoveIt! has been linted (We will see how far people get tomorrow).

@davetcoleman
Copy link
Member

+1 to running catkin_lint as a CI test.

@davetcoleman davetcoleman mentioned this issue Aug 22, 2016
Closed
@rhaschke
Copy link
Contributor

+1

@davetcoleman davetcoleman changed the title Add lint? Add catkin_lint Aug 23, 2016
@mathias-luedtke mathias-luedtke mentioned this issue Mar 9, 2017
Closed
26 tasks
@rhaschke rhaschke mentioned this issue Jan 28, 2019
Closed
@rhaschke
Copy link
Contributor

rhaschke commented Mar 9, 2019

We have this since #45 🎉

@rhaschke rhaschke closed this as completed Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@davetcoleman @v4hn @130s @rhaschke