Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename planner to pipeline in launch examples #300

Open
jschleicher opened this issue Mar 21, 2019 · 3 comments
Open

Rename planner to pipeline in launch examples #300

jschleicher opened this issue Mar 21, 2019 · 3 comments

Comments

@jschleicher
Copy link
Contributor

jschleicher commented Mar 21, 2019

Description

moveit#1397 shows, that the tutorials use planner for the planning pipeline while the setup assistant generates launch files using pipeline arguments. The tutorials should be updated to reflect the same names as in the setup_assistant launch files.

This should also update the panda_moveit_config package to be consistent with the tutorial page that references it.

@welcome
Copy link

welcome bot commented Mar 21, 2019

Thanks for reporting an issue. We will have a look asap. If you can think of a fix, please consider providing it as a pull request.

@davetcoleman
Copy link
Member

Once your moveit/moveit#1397 is merged in, please make this update @jschleicher

@jschleicher
Copy link
Contributor Author

As said in #1397: I'm not a panda expert; updating the tutorials should also re-generate the panda_moveit_config. I'm not feeling confident about making this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants