Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libs/movex] Fix linting Errors in File ClientMaster.match.spec.ts #168

Closed
GabrielCTroia opened this issue Oct 20, 2023 · 1 comment · Fixed by #175
Closed

[libs/movex] Fix linting Errors in File ClientMaster.match.spec.ts #168

GabrielCTroia opened this issue Oct 20, 2023 · 1 comment · Fixed by #175
Assignees
Labels
good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest

Comments

@GabrielCTroia
Copy link
Contributor

Where

libs/movex/src/specs/ClientMasterOrchestration/ClientMaster.match.spec.ts

What

When you run npx nx lint movex --quiet you get some errors as below:

Screenshot 2023-10-20 at 1 22 29 PM

Why is it important

Because in the close future, the linting command will be part of the Github Actions

Definition of done

  • running npx nx lint movex --quiet will not return any more errors for this file
  • tsc passes npx nx tsc movex
  • all tests pass yarn test
  • no unnecessary code is introduced
@GabrielCTroia GabrielCTroia added good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest labels Oct 20, 2023
@Abhishek-Mallick
Copy link
Contributor

Could you please assign this to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants