Return statements in void methods.

[ggutierrez]

I have a very naive question that is much related to C++ than anything else. As it occurs in several points of the mozart2 implementation I decided to ask it here :).

The following is just a method I happened to step in while debugging some behavior.

 template <class ... Args> 
  void callBuiltin(VM vm, Args &&... args) {
    if (_self.is<BuiltinProcedure>()) {
      return _self.as<BuiltinProcedure>().callBuiltin(vm, std::forward<Args>(args)...);
    } else if (_self.isTransient()) {
      waitFor(vm, _self);
      throw std::exception(); // not reachable
    } else {
      return Interface<BuiltinCallable>().callBuiltin(_self, vm, std::forward<Args>(args)...);
    }
  }

My question is simple: why method that is supposed to return nothing (i.e. void) does actually contain return statements of "values" returned by others?. Is there some purpose behind this?

[sjrd]

IIRC, these are remnants of a big refactoring that turned error codes in return values into longjmp-based exceptions. They can typically be removed.