Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 - Mozart doesn't work if installed to a path with spaces #323

Open
Etherealflux opened this issue Sep 6, 2019 · 7 comments
Open
Labels

Comments

@Etherealflux
Copy link

Mozart 2's installer defaults to dropping everything into C:\Program Files\Mozart, as is standard. However, this causes oz.exe to silently quit when run. I couldn't coerce an error message out of it, no matter how hard I tried!

Installing into C:\Mozart worked flawlessly.

I'm guessing that this isn't an easy fix, so it would make sense to just make the installer default to C:\Mozart.

@layus
Copy link
Member

layus commented Sep 6, 2019

These spaces in paths have been a pain for ages. We should really fix this. Mozart also fails at opening .oz files containing spaces.

That being said, we had a lot of successful windows 10 installs. May I ask what version you installed ?

@layus layus added the bug label Sep 6, 2019
@Etherealflux
Copy link
Author

The installer is named mozart2-2.0.1-x86_64-windows.exe, and I installed it on Windows 1803 (should really get around to that update...).

@layus
Copy link
Member

layus commented Sep 9, 2019

@anthonygego Any idea on what could be the root cause of this issue ? I know for sure it worked for many users on Windows 10.

@layus
Copy link
Member

layus commented Sep 9, 2019

First example of bad path handling in oz: a null first parameter in CreateProcess which is kind of expected to fail as per https://docs.microsoft.com/windows/win32/api/processthreadsapi/nf-processthreadsapi-createprocessa

if (!CreateProcess(NULL,buffer,NULL,NULL,TRUE,0,NULL,NULL,&si,&pi)) {

We need to track these down...

@Etherealflux
Copy link
Author

Hmm, this is odd. I just updated to Windows 1903, and now Mozart isn't working again..except in one case.

  • If I run it from the Start Menu, a Powershell window opens, hangs there for a moment, and then vanishes.
  • If I open Powershell 5.1 (Build 18362, Revision 145) and run .\oz.exe or ./oz.exe, the program quits silently.
  • If I open Powershell 7.0 and run .\oz.exe or ./oz.exe, the same thing happens.
  • If I run bash (I'm not sure where that's even coming from..) and then run ./oz.exe, it works.

I wonder if this is an issue with environment variables or something similar?

@anthonygego
Copy link
Contributor

@layus The doc seems to say that as long as the executable name is put between quotes, this should work anyway. However it would be better to do this correctly and "fix" it :-)
@Etherealflux oz.exe actually simply launches emacs with some parameters. Are you able to launch emacs from those shells ?

@Etherealflux
Copy link
Author

Ah, so you think it's an environment problem? That would make sense - I will check that when I get the chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants