Allow user to supply via attribute whether they want the indicator enabled #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21 (or so I hope)
Hi there
indicator="disabled"
in this PR will allow the user to declare whether they want the indicator animating or notIdeally, the indicator element itself would be hidden entirely (this is not the case)
I wasn't entirely sure how to expose an attribute/property that a user could call externally (via inspect &
$0.indicator
or otherwise), and the code here looks quite different than https://developer.mozilla.org/en-US/Apps/Tools_and_frameworks/Web_components so I figured I'd start this PR to start the conversationLet me know what you think