Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution for predictable filenames #19

Closed
escapewindow opened this issue Mar 12, 2020 · 2 comments
Closed

solution for predictable filenames #19

escapewindow opened this issue Mar 12, 2020 · 2 comments
Assignees

Comments

@escapewindow
Copy link
Contributor

Currently, web-ext hardcodes the filepath web-ext-artifacts/LOWERCASE_PACKAGE-VERSION.zip. This means that we can't reliably determine what the artifact name will be from xpi-manifest, without downloading all the respective package.json files for each xpi. (This latter approach would be simplified if we used a monorepo, but as of this writing that goes against our current requirements.)

The current workaround is to wrap the web-ext build with a script that renames the artifact afterwards. That's one approach, but it seems unwieldy, since web-ext is a Mozilla project.

The best solution appears to be adding an option to web-ext to specify a filepath or filepath template. I filed mozilla/web-ext#1844 , which was duped to mozilla/web-ext#1335 . There appears to be an abandoned patchset for the latter issue; we can potentially unbitrot it and get it landable.

This is on my todo list back burner for when I have time, but I'm happy for any help here as well.

@escapewindow
Copy link
Contributor Author

mozilla/web-ext#1900 landed on May 11. I pinged to see if/when we can get a new release of web-ext. Once that happens, we can resolve this.

@escapewindow escapewindow self-assigned this Jun 10, 2020
@escapewindow
Copy link
Contributor Author

web-ext 4.3.0 supports web-ext build --filename . #33 tracks specifying the artifact name in package.json if we want further customizability. Resolving this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant