Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build your own custom dashboard #195

Open
armenzg opened this issue Aug 29, 2019 · 11 comments
Open

Build your own custom dashboard #195

armenzg opened this issue Aug 29, 2019 · 11 comments

Comments

@armenzg
Copy link
Contributor

armenzg commented Aug 29, 2019

Nbp mentions:

I would mostly care about a few of
these benchmarks, and I would appreciate to have a "Custom" list of
benchmarks (for example: ares6, octane, kraken, sunspider), where the
list is kept in a cookie/local-storage/indexdb.
Others might prefer, tp6 / WebAssembly / … based on what they are
actively working on.

@divyanshu-rawat
Copy link
Collaborator

@armenzg Could you please let me know what this issue is all about?

@armenzg
Copy link
Contributor Author

armenzg commented Jan 6, 2020

Do you remember the two config files you were handling it on the last PR?

Imagine a page that the user could add the benchmarks they want to see instead of a preset.

The benchmarks chosen would then be stored locally it in their localStorage. That way the next time they visit that page they will be able to see the benchmarks they care about.

@divyanshu-rawat
Copy link
Collaborator

@armenzg yes I do, so you mean some if else condition that say load presets from local storage if there aren't any then go with default one, but how they will chose the benchmarks that they want to store, like any specific UI needs to be implemented for that?

@armenzg
Copy link
Contributor Author

armenzg commented Jan 16, 2020

You can use this page as inspiration:
https://treeherder.mozilla.org/perf.html#/graphs
image

You can even copy the code from treeherder into the project if you like.

@divyanshu-rawat
Copy link
Collaborator

Thanks @armenzg I will have a look 👍😅.

@divyanshu-rawat
Copy link
Collaborator

divyanshu-rawat commented Jan 17, 2020

@armenzg here https://treeherder.mozilla.org/perf.html#/graphs we have 2 buttons when to select the date and other is to select the test data, do you also plan to have a dropdown for date as well or only a button so that user can add the benchmarks.

@armenzg
Copy link
Contributor Author

armenzg commented Jan 20, 2020

Just the benchmarks. Thanks!

@armenzg
Copy link
Contributor Author

armenzg commented Jan 31, 2020

@divyanshu-rawat how is it going? Please let me know if you're still going to pursue this or if I should find another contributor. Have a good weekend.

@divyanshu-rawat
Copy link
Collaborator

@armenzg I haven't started working on will work on it in upcoming week, I am occupied these days with my full time job & some personal stuffs. :) , I hope you understand. 👍

@armenzg
Copy link
Contributor Author

armenzg commented Feb 4, 2020

Of course! Thanks for updating me!

@divyanshu-rawat
Copy link
Collaborator

@armenzg I will start working on it tomorrow , will ping you If I face any problems. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants