Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

Fixes related to maws prompt #216

Merged
merged 3 commits into from
May 13, 2020
Merged

Fixes related to maws prompt #216

merged 3 commits into from
May 13, 2020

Conversation

april
Copy link
Contributor

@april april commented May 4, 2020

  • Change prompt to always use role name, never profile name
  • Stop overloading profile_name and use previously unused self.role
  • Change function name to indicate actual function
  • Fix slightly unrelated bug with using -o awscli or -o shared without a profile name

Fixes #215.

@april
* Change prompt to always use role name, never profile name
9587b46 
* Stop overloading `profile_name` and use previously unused `self.role`
* Change function name to indicate actual function
* Fix slightly unrelated bug with using `-o awscli` or `-o shared` without a profile name
@april april requested a review from gene1wood May 4, 2020 22:18
gene1wood
gene1wood suggested changes May 5, 2020
View reviewed changes
Copy link
Contributor

@gene1wood gene1wood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to retain the current functionality where by default the tool picks a descriptive AWS profile name if none is provided.

mozilla_aws_cli/cli.py Outdated Show resolved Hide resolved
mozilla_aws_cli/login.py Show resolved Hide resolved
mozilla_aws_cli/utils.py Outdated Show resolved Hide resolved
@staktrace
Copy link

Hi, any ETA on merging this?

@april
Copy link
Contributor Author

april commented May 12, 2020

@gene1wood, do you want to review the changes from your feedback, or should I merge?

@gene1wood
Copy link
Contributor

I'll PR a change to the name of the variable for the display name.

@gene1wood gene1wood merged commit 929fc19 into mozilla-iam:master May 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gene1wood gene1wood gene1wood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change prompt to show fixed account and role instead of MAWS_PROFILE
3 participants
@april @staktrace @gene1wood