UI: Improve "Add thing" page

[rzr]

A few remarks about "Add thing page"

I noticed that the "Done" button is not appearing at bottom when thing is added explicitly by URL instead of relying on widgets of discovered resources...

When adding thing by URL AFAIK there is no done button anymore, so user have hit the back button to see the thing on dashboard.

Anyway from a UI/UX perspective, scrolling down to make the "done" button is not obvious,
it would be more logic to have that button next to the resource, and eventually rename skip the "save" step.

I just had a quick view of code and new-thing.js's handleSave and new-web-thing.js save methods are close enough to be refactored, arent they ?

Can we also avoid to reload this addon when adding by URL ?

Maybe this can be forwarded to:
https://github.com/mozilla-iot/thing-url-adapter/

[rzr]

Also the same resource can be "added twice" (by mDNS and URL) and appears duplicated on dashboard, is this desired ?

[hobinjk]

I think the "Done" issue is tracked by #1386. When adding a thing by url I still see the cancel/done button even if there were no other things to add There's definitely room for improvement in multiple areas. The duplication is vaguely intentional since the mDNS thing has an identifier of "whatever.local" whereas the added by url should have a concrete IP address like "192.168.1.103". Ideally there could be a warning if the IP address has an associated DNS record and vice-versa but it's pretty hard to accidentally get this behavior.

…

On 10/8/18 11:04 AM, Philippe Coval wrote: Also the same resource can be "added twice" (by mDNS and URL) and appears duplicated on dashboard, is this desired ? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1393 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACpcGeTEmEYKuKTweVzTtUo2ISqtlgdiks5ui2mNgaJpZM4XNGnR>.

[flatsiedatsie]

Adding a "rescan" button would also be very welcome. Right now I have to go back and then click on "add devices" in the main menu again.