Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: Add LevelSensor doc and demo video #25

Merged
merged 2 commits into from
Jul 27, 2018

Conversation

rzr
Copy link
Collaborator

@rzr rzr commented Jul 26, 2018

makefile fixes too , I reverted it to earlier version, sorry I should have tested it more.

please confirm you can build it as explained in readme

rzr added 2 commits July 26, 2018 18:27
Other included makefiles are defining common rules,
so we use the "rule/" namespace

Change-Id: Ide5a7444f25181169eb46e434e385d94e15a2dec
Signed-off-by: Philippe Coval <p.coval@samsung.com>
Change-Id: I4db943568d9146588db2ddd270d06cb15efca947
Signed-off-by: Philippe Coval <p.coval@samsung.com>
@hobinjk
Copy link
Contributor

hobinjk commented Jul 26, 2018

Sorry, my linux VM is having issues so I unfortunately can't test the full makefile. When I try to run it locally it's unable to find the Ethernet library which I would guess is just a difference of paths between mac and linux.

@rzr
Copy link
Collaborator Author

rzr commented Jul 26, 2018

maybe just override using:

make rule/setup arduino_host=macosx

It should unpack:

https://downloads.arduino.cc/arduino-1.8.5-macosx.zip

Then I could test ${OSTYPE} or uname to support the other unix :)

@hobinjk
Copy link
Contributor

hobinjk commented Jul 26, 2018

Unfortunately that doesn't work since it's a zip and it's piped into tar -xJ

@hobinjk
Copy link
Contributor

hobinjk commented Jul 27, 2018

Okay, testing on my ubuntu VM I'm getting the error that avr-gcc is not found despite it definitely being there. I'm also getting an interesting warning. Sorry for these being screenshots, copy-paste is not working right now:
screen shot 2018-07-27 at 10 57 17 am
screen shot 2018-07-27 at 10 51 09 am

@rzr
Copy link
Collaborator Author

rzr commented Jul 27, 2018

I am downloading 32bit bins (so you might miss 32bits libs) maybe you can override make arduino_host=linux64

@hobinjk
Copy link
Contributor

hobinjk commented Jul 27, 2018

Oh right! Specifying linux64 causes everything to work perfectly

@rzr
Copy link
Collaborator Author

rzr commented Jul 27, 2018

Of course this can be improved we can even setup a docker or travis job would that help ?

@hobinjk
Copy link
Contributor

hobinjk commented Jul 27, 2018

For now I'm good with just having the makefile as an option. If you want to add a dockerfile or a travis job that would be very cool

@hobinjk hobinjk merged commit 36fea84 into WebThingsIO:master Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants