Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Move CrashReporter to engine abstraction #4052

Closed
jonalmeida opened this issue Aug 7, 2019 · 2 comments
Closed

Move CrashReporter to engine abstraction #4052

jonalmeida opened this issue Aug 7, 2019 · 2 comments
Labels
⌨️ code Technical debt, code clean up, small API change ..

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Aug 7, 2019

We use the Gecko CrashReporter directly in lib-crash and compile it against GeckoView Nightly only. This lead to a breaking API change on the crash report that exists in nightly but not in beta/release.

Since the crash reporter doesn't have the powers of the engine abstraction we've built for the different variants of Gecko, we had to put in a hacky change that fixes this those versions.

What we should do is to abstract out the crash reporter into the engine so that we can avoid this issue in the future (and also remove our original patch).

┆Issue is synchronized with this Jira Task

@jonalmeida jonalmeida added the ⌨️ code Technical debt, code clean up, small API change .. label Aug 7, 2019
@pocmo
Copy link
Contributor

pocmo commented Aug 12, 2019

Looks like a duplicate of #2203

@jonalmeida
Copy link
Contributor Author

Closing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⌨️ code Technical debt, code clean up, small API change ..
Projects
None yet
Development

No branches or pull requests

2 participants