Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

AccountObserver: differentiate between sign-in and sign-up #4238

Closed
grigoryk opened this issue Aug 27, 2019 · 3 comments · Fixed by #4221
Closed

AccountObserver: differentiate between sign-in and sign-up #4238

grigoryk opened this issue Aug 27, 2019 · 3 comments · Fixed by #4221
Labels
<firefox-accounts> Component: FxA
Milestone

Comments

@grigoryk
Copy link
Contributor

grigoryk commented Aug 27, 2019

We'll need this for telemetry purposes.

Also: currently there's a flag - newAccount - which differentiates between "sign-in/sign-up and restore". That's a potentially misleading name, in retrospect. For example, due to a mistake Fenix treats it as a flag differentiating between "sign-in and sign-up". Let's rename that to isRestore, or similar.

┆Issue is synchronized with this Jira Task

@grigoryk grigoryk added the <firefox-accounts> Component: FxA label Aug 27, 2019
@rfk
Copy link
Contributor

rfk commented Aug 27, 2019

From our previous discussion in slack, where I misunderstood you wanting this for Fenix instead of Fennec:

"""
when signing in to OAuth reliers on the web, we do appear to include an action=signin or action=signup query parameter to let them know whether it was a new or existing account; I wonder if Fenix also gets this today on the OAuth flow (edited)
"""

So I expect that you already get this information from FxA at the completion of the OAuth flow.

@grigoryk
Copy link
Contributor Author

grigoryk commented Aug 27, 2019

@rfk we do receive it via the login-oauth webchannel message.

@rfk
Copy link
Contributor

rfk commented Aug 28, 2019

What I mean is, you can probably get this information today in the OAuth redirect, without having to wait for thwe webchannel stuff to land. (Which may or may not be useful information, just wanted to note it explicitly).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
<firefox-accounts> Component: FxA
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants