Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

pressing back button should return to history #1031

Closed
cadeyrn opened this issue Mar 15, 2019 · 2 comments
Closed

pressing back button should return to history #1031

cadeyrn opened this issue Mar 15, 2019 · 2 comments

Comments

@cadeyrn
Copy link
Contributor

cadeyrn commented Mar 15, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Menu > Your Library > History
  2. click on a website from your history
  3. press the back button of your device

Expected behavior

You return to the history view.

Actual behavior

You are on the Fenix home screen.

Device information

  • Android device: HTC U11 / Android 8.0
  • Fenix version: Fenix revision 9255962

┆Issue is synchronized with this Jira Task
@vesta0 vesta0 added the 🐞 bug Crashes, Something isn't working, .. label Mar 19, 2019
@ekager
Copy link
Contributor

ekager commented Mar 19, 2019

I think this isn't necessarily a "bug" and we need UX feedback on this.
Chrome opens History similar to how Fenix does (in its own fragment) and clicking back after opening an item does not bring you back to History.
Fennec opens history in a view inside of the current tab, and selecting an item and pressing back does take you back to History.
The engineering instinct was to pop to the home screen when the user selects a history item so that pressing back does not take you back to history and muddy the backstack, but it is a trivial change if UX decides differently.

@ekager ekager added needs:UX-feedback Needs UX Feedback and removed 🐞 bug Crashes, Something isn't working, .. labels Mar 19, 2019
@vesta0 vesta0 added the P1 Current sprint label Mar 29, 2019
@boek
Copy link
Contributor

boek commented Mar 29, 2019

dup of #1012

@boek boek closed this as completed Mar 29, 2019
@ghost ghost removed the P1 Current sprint label Mar 29, 2019
@vesta0 vesta0 removed the needs:UX-feedback Needs UX Feedback label Apr 1, 2019
@data-sync-user data-sync-user changed the title pressing back button should return to history FNX2-15867 ⁃ pressing back button should return to history Jul 30, 2020
@data-sync-user data-sync-user changed the title FNX2-15867 ⁃ pressing back button should return to history FNX-4737 ⁃ pressing back button should return to history Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-4737 ⁃ pressing back button should return to history FNX3-13802 ⁃ pressing back button should return to history Aug 10, 2020
@cadeyrn cadeyrn closed this as completed Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13802 ⁃ pressing back button should return to history FNX-4737 ⁃ pressing back button should return to history Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-4737 ⁃ pressing back button should return to history FNX2-15867 ⁃ pressing back button should return to history Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-15867 ⁃ pressing back button should return to history pressing back button should return to history May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cadeyrn @boek @ekager @vesta0 @data-sync-user