Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

"users" in add-ons manager should be renamed #11570

Closed
cadeyrn opened this issue Jun 14, 2020 · 7 comments
Closed

"users" in add-ons manager should be renamed #11570

cadeyrn opened this issue Jun 14, 2020 · 7 comments
Assignees
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:WebExtensions good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue.

Comments

@cadeyrn
Copy link
Contributor

cadeyrn commented Jun 14, 2020

The add-ons manager shows a "users" number but this number does not represent the number of users but the numbers of reviews. It causes confusion even for Mozilla staff as seen in #10002 (comment), so it won't be easier to understand for the average user. I suggest to rename it to "reviews" for two reasons:

  1. It's not obvious that with "users" the "number of users who have submitted a review" is meant. The term "reviews" better reflects the reality. As user "users" mean "number of users" for me, even if it's placed to the right of the rating stars.
  2. Firefox for Desktop already uses the term "reviews" for the same number in the add-ons manager and Firefox for Android should use the same term as Firefox for Desktop to be consistent.

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 14, 2020
@csadilek csadilek removed the needs:triage Issue needs triage label Jun 15, 2020
@ValentinTimisica ValentinTimisica added the needs:UX-feedback Needs UX Feedback label Jun 19, 2020
@AmyYLee AmyYLee added needs:strings Needs strings and removed needs:UX-feedback Needs UX Feedback labels Jun 24, 2020
@AmyYLee
Copy link
Collaborator

AmyYLee commented Jun 24, 2020

@betsymi for reviewing strings

@cadeyrn
Copy link
Contributor Author

cadeyrn commented Jul 29, 2020

@betsymi You probably missed that - could you please confirm that this change is okay (or otherwise say that it shouldn't be changed)? Thanks! 🙂

@betsymi
Copy link

betsymi commented Jul 29, 2020

@betsymi You probably missed that - could you please confirm that this change is okay (or otherwise say that it shouldn't be changed)? Thanks! 🙂

I did miss this, thanks for flagging! I agree with your recommendation to use Reviews instead.

@NotWoods NotWoods added eng:ready Ready for engineering good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue. labels Jul 29, 2020
@assemble-code
Copy link
Contributor

I would like to work on this, please assign it

@Ankur-Khandelwal
Copy link
Contributor

I would like to contribute to this.

@data-sync-user data-sync-user changed the title "users" in add-ons manager should be renamed FNX3-14735 ⁃ "users" in add-ons manager should be renamed Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14735 ⁃ "users" in add-ons manager should be renamed FNX-12522 ⁃ "users" in add-ons manager should be renamed Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12522 ⁃ "users" in add-ons manager should be renamed FNX2-13520 ⁃ "users" in add-ons manager should be renamed Aug 11, 2020
@Mugurell Mugurell removed the needs:strings Needs strings label Aug 24, 2020
@Mugurell
Copy link
Contributor

Should be ready to test in the next nightly.

@Mugurell Mugurell added the eng:qa:needed QA Needed label Aug 24, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Aug 26, 2020

Hi, verified as fixed on the latest Nightly Build 200826 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 10)
• OnePlus A3 (Android 6.0.1)

► Video
20200826-094154

@AndiAJ AndiAJ closed this as completed Aug 26, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 26, 2020
@data-sync-user data-sync-user changed the title FNX2-13520 ⁃ "users" in add-ons manager should be renamed "users" in add-ons manager should be renamed May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:WebExtensions good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue.
Projects
None yet
Development

No branches or pull requests